Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fixed an issue where ForEachAssembly() didn't catch a TypeLoadException that can be thrown by GetCustomAttributes().#5

Open
binarynate wants to merge 1 commit intoUnity-Technologies:masterUnity-Technologies/ConditionalCompilationUtility:masterfrom
binarynate:fix-TypeLoadExceptionbinarynate/ConditionalCompilationUtility:fix-TypeLoadExceptionCopy head branch name to clipboard
Open

Fixed an issue where ForEachAssembly() didn't catch a TypeLoadException that can be thrown by GetCustomAttributes().#5
binarynate wants to merge 1 commit intoUnity-Technologies:masterUnity-Technologies/ConditionalCompilationUtility:masterfrom
binarynate:fix-TypeLoadExceptionbinarynate/ConditionalCompilationUtility:fix-TypeLoadExceptionCopy head branch name to clipboard

Conversation

@binarynate
Copy link

@binarynate binarynate commented Jan 5, 2023

Hi 👋🏻. I use ConditionalCompilationUtility in a library called 3D WebView, and a user contacted me about an issue where an uncaught TypeLoadException was being thrown by ConditionalCompilationUtility. Here's the stack trace they sent me:

TypeLoadException: Could not resolve type with token 01000008 from typeref (expected class 'System.Resources.NeutralResourcesLanguageAttribute' in assembly 'System.Runtime, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a')
System.MonoCustomAttrs.GetCustomAttributesBase (System.Reflection.ICustomAttributeProvider obj, System.Type attributeType, System.Boolean inheritedOnly) (at <75633565436c42f0a6426b33f0132ade>:0)
System.MonoCustomAttrs.GetCustomAttributes (System.Reflection.ICustomAttributeProvider obj, System.Boolean inherit) (at <75633565436c42f0a6426b33f0132ade>:0)
System.Reflection.RuntimeAssembly.GetCustomAttributes (System.Boolean inherit) (at <75633565436c42f0a6426b33f0132ade>:0)
Vuplex.WebView.ConditionalCompilation.ConditionalCompilationUtility+<>c__DisplayClass9_0.<UpdateDependencies>b__1 (System.Reflection.Assembly assembly) (at Assets/Vuplex/WebView/Core/Editor/Scripts/ConditionalCompilationUtility.cs:191)
Vuplex.WebView.ConditionalCompilation.ConditionalCompilationUtility.ForEachAssembly (System.Action`1[T] callback) (at Assets/Vuplex/WebView/Core/Editor/Scripts/ConditionalCompilationUtility.cs:252)
Vuplex.WebView.ConditionalCompilation.ConditionalCompilationUtility.UpdateDependencies (System.Boolean reset) (at Assets/Vuplex/WebView/Core/Editor/Scripts/ConditionalCompilationUtility.cs:189)

I updated the version of CCU that ships with 3D WebView to incorporate the change in this PR and the user confirmed that it resolved the issue for them. I'm just submitting this change in a PR now to help others avoid it in the future.

@binarynate
Fixed an issue where ForEachAssembly() didn't catch a TypeLoadExcepti…
a9b0df0 
…on that can be thrown by GetCustomAttributes().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@binarynate

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.