Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Sep 17, 2021. It is now read-only.
This repository was archived by the owner on Sep 17, 2021. It is now read-only.

Add ERC-20 compatibility check when creating a new exchange #49

Copy link
Copy link
@gundas

Description

@gundas
Issue body actions

Hello,
I have a small suggestion - currently Uniswap has about 2400 exchanges deployed. A few of the tokens (still) do no fully support ERC-20. The worst was BNB, but there are others - PKG, XYO etc.

Maybe it would be a good idea to a do a simple token compatibility test when creating a new exchange:

assert(token.transferFrom(msg.sender, address(this),1))
assert(token.transfer(msg.sender,1))

This small check would prevent people from loosing money.

What do you think? Maybe it is not too late to implement it in V2?

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.