Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 7 commits
- 249 files changed
- 3 contributors
Commits on Aug 18, 2022
-
Give messages when sickness countdown has nearly expired to warn player that hero is dying and also so that death at the end doesn't seem so abrupt after an arbitrary period with just "TermIll" and/or "FoodPois" on the status line. Also, abuse constitution each turn when Sick (either variation, but not a double amount if both). Cherry picked from NetHack/NetHack@4eb0592959
-
Remove NetHack code specific function declaration
Replaces all STATIC_ defines with static. Removes all instances of NDECL and FDECL. Drops last remains of OVL and USE_TRAMPOLI.
-
Change all K&R style function definitions
Compiles now on GCC with -Werror=old-style-definition and -Werror=old-style-declaration.
-
-
Change xchar to other typedefs
One of the drivers of this change was that screen coordinates require a type that can hold values greater than 127. Parameters to the window port routines require a large type in order to be able to have values a fair bit larger than COLNO and ROWNO passed to them, particularly for their use to the right of the map window. This splits the uses of xchar into 3 different situations, and adjusts their type and size: xchar | ----------------------- | | | coordxy xint16 xint8 coordxy: Actual x or y coordinates for various things (moved to 16-bits). xint16: Same data size as coordxy, but for non-coordinate use (16-bits). xint8: There are only a few use cases initially, where it was very plain to see that the variable could remain as 8-bits, rather than be bumped to 16-bits. There are probably more such cases that could be changed after additional review. UnNetHack specific note: First all xint8 and xint16 instances were copied over from vanilla. Then all remaining instances of xchar were replaced with coordxy and all type mismatching catched by the compiler fixed. Mostly equivalent with NetHack/NetHack@30b557f7d5 and NetHack/NetHack@3004cf2d3 -
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...code_cleanup