Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: eliminate 10k char limit on agent messages #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PopescuTudor merged 1 commit into from
Sep 10, 2025
Merged

feat: eliminate 10k char limit on agent messages #553

PopescuTudor merged 1 commit into from
Sep 10, 2025

Conversation

@PopescuTudor
Copy link
Collaborator

@PopescuTudor PopescuTudor commented Sep 8, 2025 •
edited by github-actions bot
Loading

Development Package

  • Add this package as a dependency in your pyproject.toml:
[project]
dependencies = [
  # Exact version:
  "uipath==2.1.39.dev1005530989",

  # Any version from PR
  "uipath>=2.1.39.dev1005530000,<2.1.39.dev1005540000"
]

[[tool.uv.index]]
name = "testpypi"
url = "https://test.pypi.org/simple/"
publish-url = "https://test.pypi.org/legacy/"
explicit = true

[tool.uv.sources]
uipath = { index = "testpypi" }

@PopescuTudor PopescuTudor added the build:dev Create a dev build from the pr label Sep 8, 2025
@PopescuTudor PopescuTudor force-pushed the feat/message-len-limit branch 8 times, most recently from 5b66e4c to 1303248 Compare September 9, 2025 15:58
@PopescuTudor PopescuTudor marked this pull request as ready for review September 9, 2025 16:04
radu-mocanu
radu-mocanu reviewed Sep 10, 2025
View reviewed changes
src/uipath/_services/jobs_service.py Outdated
"""
if job.output_file:
# Large output stored as attachment
temp_path = os.path.join(self._temp_dir, f"output_{job.output_file}")
Copy link
Collaborator

@radu-mocanu radu-mocanu Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should delete the tempdir after usage. please check:

uipath-python/src/uipath/_cli/_evals/evaluation_service.py

Line 355 in ae9f0c8

with tempfile.TemporaryDirectory() as tmpdir:

the logic inside create_attachment and create_attachment_async methods should also be updated.

Copy link
Collaborator Author

@PopescuTudor PopescuTudor Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logic inside create_attachment and create_attachment_async uses a temp file only when no job is available, intended for local development/debugging (as stated in the methods' descriptions). I wouldn't change it to a mechanism that only keeps a temporary file during a with... context.

uipath-python/src/uipath/_services/jobs_service.py

Line 616 in ae9f0c8

Note:

@PopescuTudor PopescuTudor merged commit 21e8c5a into main Sep 10, 2025
16 checks passed
@PopescuTudor PopescuTudor deleted the feat/message-len-limit branch September 10, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@radu-mocanu radu-mocanu radu-mocanu approved these changes

@cristipufu cristipufu Awaiting requested review from cristipufu

Assignees

No one assigned

Labels

build:dev Create a dev build from the pr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PopescuTudor @radu-mocanu
Morty Proxy This is a proxified and sanitized view of the page, visit original site.