Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix kubectl cluster-info dump command and add test coverage #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

GulajavaMinistudio
Copy link

… frame (NativeScript#6857)

  • feat(HMR): apply changes in page styles at runtime

  • fix: livesync tests

  • test: changeCssFile method

  • refactor: address comments

Add a comment.
Update let to const.
Update changesCssFile test.

  • test: add an assert

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

… frame (#6857)

* feat(HMR): apply changes in page styles at runtime

* fix: livesync tests

* test: changeCssFile method

* refactor: address comments

Add a comment.
Update `let` to `const`.
Update `changesCssFile` test.

* test: add an assert
@GulajavaMinistudio GulajavaMinistudio merged commit 36f1dea into TypescriptID:master Feb 14, 2019
GulajavaMinistudio pushed a commit that referenced this pull request Mar 21, 2019
As requested in ST 1341351, this PR replaces the throw if `files` is null.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.