Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

3.0 CI Bugs#1261

Merged
jlarson4 merged 4 commits intodevTransformerLensOrg/TransformerLens:devfrom
bug/ci-glitches-3.0TransformerLensOrg/TransformerLens:bug/ci-glitches-3.0Copy head branch name to clipboard
Apr 20, 2026
Merged

3.0 CI Bugs#1261
jlarson4 merged 4 commits intodevTransformerLensOrg/TransformerLens:devfrom
bug/ci-glitches-3.0TransformerLensOrg/TransformerLens:bug/ci-glitches-3.0Copy head branch name to clipboard

Conversation

@jlarson4
Copy link
Copy Markdown
Collaborator

Description

  • Updated utils imports to utilities
  • Updated CI to only run LLaMA notebooks when the HF_TOKEN is available (not available on Fork PRs)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

@jlarson4 jlarson4 changed the title Bug/ci glitches 3.0 3.0 CI Bugs Apr 20, 2026
@jlarson4 jlarson4 merged commit 98811df into dev Apr 20, 2026
43 of 44 checks passed
jlarson4 added a commit that referenced this pull request Apr 20, 2026
* Fix type of HookedTransformerConfig.device

This is typed as `Optional[str]` but sometimes returns `torch.device`.
Updated the code to just return the `str` instead of wrapping with a
device.

I'm not confident that every function which takes a device will
always be passed a string, so I didn't change functions like
warn_if_mps.

Found while working on #1219

* more cleanup

* 3.0 CI Bugs (#1261)

* Fixing `utils` imports

* skip gated notebooks on PR from forks

* Updating notebooks

* Ensure LLaMA only runs when HF_TOKEN is available

---------

Co-authored-by: jlarson4 <jonahalarson@comcast.net>
jlarson4 added a commit that referenced this pull request May 4, 2026
* Fix type of HookedTransformerConfig.device

This is typed as `Optional[str]` but sometimes returns `torch.device`.
Updated the code to just return the `str` instead of wrapping with a
device.

I'm not confident that every function which takes a device will
always be passed a string, so I didn't change functions like
warn_if_mps.

Found while working on #1219

* more cleanup

* 3.0 CI Bugs (#1261)

* Fixing `utils` imports

* skip gated notebooks on PR from forks

* Updating notebooks

* Ensure LLaMA only runs when HF_TOKEN is available

---------

Co-authored-by: jlarson4 <jonahalarson@comcast.net>
jlarson4 added a commit that referenced this pull request May 7, 2026
* Fix type of HookedTransformerConfig.device (#1230)

* Fix type of HookedTransformerConfig.device

This is typed as `Optional[str]` but sometimes returns `torch.device`.
Updated the code to just return the `str` instead of wrapping with a
device.

I'm not confident that every function which takes a device will
always be passed a string, so I didn't change functions like
warn_if_mps.

Found while working on #1219

* more cleanup

* 3.0 CI Bugs (#1261)

* Fixing `utils` imports

* skip gated notebooks on PR from forks

* Updating notebooks

* Ensure LLaMA only runs when HF_TOKEN is available

---------

Co-authored-by: jlarson4 <jonahalarson@comcast.net>

* feat: Add MPS CI runner support (#1264)

* ci: Enable runs on feature branch

* fix: Skip heavy model_bridge unit tests on MPS runner due to memory limits

* fix: Ignore flaky grouped query attention tests on Mac runner

* style: Run make format on test_mps_basic.py

* style: Standardize MPS step naming convention in CI

* ci: Revert MPS trigger to run only on main PRs and pushes

* ci: Remove feature branch from global workflow triggers

* fix: Restore torch.device return type in get_device for API stability

* docs: Align train and device config docstrings with implementation

* fix: Update device type hints to Union[str, torch.device] for consistency

* ci: Update mps-checks trigger to include dev branch

* test: Update device tests for torch.device compatibility and robustness

* ci: Restrict MPS trigger to main branch only

* ci: Pass HF_TOKEN to MPS check jobs

* fix: Revert device type hints and tests to strictly use strings

* ci: Refine MPS test coverage

* cleanup: Remove unused no_mps marker

* fix: Remove unused Union import in lit/model.py

* ci: Temporarily enable dev trigger for verification

* ci: Re-ignore tests that fail with NaNs or precision errors on MPS

* ci: Restrict MPS trigger to main branch

* fix: Use torch.allclose for GQA tests to allow MPS float precision delta

* ci: Enable MPS checks on dev branches

* style: Run make format on test_grouped_query_attention.py

* ci: Revert MPS trigger to run only on main PRs and pushes

---------

Co-authored-by: Brendan Long <self@brendanlong.com>
Co-authored-by: jlarson4 <jonahalarson@comcast.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.