Fix StandardInput singleton bug#296
Open
eidursveinn wants to merge 1 commit intoTouchScript:developTouchScript/TouchScript:developfrom
eidursveinn:fix-standardinput-singleton-bugeidursveinn/TouchScript:fix-standardinput-singleton-bugCopy head branch name to clipboard
Open
Fix StandardInput singleton bug#296eidursveinn wants to merge 1 commit intoTouchScript:developTouchScript/TouchScript:developfrom eidursveinn:fix-standardinput-singleton-bugeidursveinn/TouchScript:fix-standardinput-singleton-bugCopy head branch name to clipboard
eidursveinn wants to merge 1 commit intoTouchScript:developTouchScript/TouchScript:developfrom
eidursveinn:fix-standardinput-singleton-bugeidursveinn/TouchScript:fix-standardinput-singleton-bugCopy head branch name to clipboard
Conversation
Previously the logic only checked whether the variable storing the singleton instance was null and if not destroyed it. However that doesn't take into account that the StandardInput component may have been disabled and then re-enabled and that this is the same instance as the one we had stored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the bug?
Previously the logic only checked whether the variable storing the singleton instance was null and if not destroyed it. However that doesn't take into account that the StandardInput component may have been disabled and then re-enabled and that this is the same instance as the one we had previously stored as the singleton instance.
This branch fixes that by adding a check for whether this is the same instance as we stored.