Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@maowug
Copy link
Contributor

@maowug maowug commented Oct 10, 2016

Change:

  • typo: lowpriority extractor implicits

trait SeqExtractor moved to the same scope with trait Extractor. It makes more sense to put SeqExtractor outside LowPriorityExtractor(Implicits).

@Atry
Copy link
Collaborator

Atry commented Oct 10, 2016

http://docs.scala-lang.org/style/files.html

As a rule, files should contain a single logical compilation unit. By “logical” I mean a class, trait or object.

@maowug
Copy link
Contributor Author

maowug commented Oct 10, 2016

@Atry Done. Didn't notice the file name.

@Atry Atry merged commit 3dd4a30 into ThoughtWorksInc:master Oct 10, 2016
@Atry
Copy link
Collaborator

Atry commented Oct 10, 2016

Thank you. I prefer to keep SeqExtractor in Extractor for backward-compatibility.

Atry added a commit that referenced this pull request Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.