Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Added Factorial in Java#932

Merged
jrg94 merged 2 commits intomasterTheRenegadeCoder/sample-programs:masterfrom
java-factTheRenegadeCoder/sample-programs:java-factCopy head branch name to clipboard
Dec 31, 2018
Merged

Added Factorial in Java#932
jrg94 merged 2 commits intomasterTheRenegadeCoder/sample-programs:masterfrom
java-factTheRenegadeCoder/sample-programs:java-factCopy head branch name to clipboard

Conversation

@auroq
Copy link
Contributor

@auroq auroq commented Dec 31, 2018

Congrats on taking the first step to contributing to the Sample Programs in Every Language repository!

For simplicity, please make sure that your pull request includes one and only one sample program and language.

Please Complete the Following

  • I would NOT like credit for my contribution in the article (credit will be included otherwise)
  • I plan to write the article for this code snippet
  • I named the pull request using <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)
  • I fixed Add Factorial in Java #930

Notes

Feel free to put whatever you want here.

@auroq auroq added enhancement Any code that improves the repo factorial See: https://sampleprograms.io/projects/factorial/ labels Dec 31, 2018
@auroq auroq added this to the 250 Snippets milestone Dec 31, 2018
@auroq
Copy link
Contributor Author

auroq commented Dec 31, 2018

Reliably goes up to 59! Gotta love that java efficiency. 😛

@auroq auroq requested review from a team and jrg94 December 31, 2018 00:33
jrg94
jrg94 requested changes Dec 31, 2018
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs great! I'm partial to braces no matter what in Java, but that's just me 😉. haha Nice work.

jrg94
jrg94 reviewed Dec 31, 2018
View reviewed changes
archive/j/java/Factorial.java Outdated Show resolved Hide resolved
@jrg94 jrg94 self-assigned this Dec 31, 2018
jrg94
jrg94 approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! This will become number 250. I'll hold off on merges until I get the release through.

@jrg94 jrg94 merged commit 6d412d0 into master Dec 31, 2018
@jrg94 jrg94 deleted the java-fact branch December 31, 2018 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrg94 jrg94 jrg94 approved these changes

Assignees

@jrg94 jrg94

Labels

enhancement Any code that improves the repo factorial See: https://sampleprograms.io/projects/factorial/

Projects

Code Snippets
Archived in project

Milestone

250 Snippets

Development

Successfully merging this pull request may close these issues.

Add Factorial in Java

2 participants

@auroq @jrg94
Morty Proxy This is a proxified and sanitized view of the page, visit original site.