Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Added Longest Palindromic Substring in Python#1214

Merged
jrg94 merged 11 commits intoTheRenegadeCoder:masterTheRenegadeCoder/sample-programs:masterfrom
PaulSayantan:masterCopy head branch name to clipboard
Oct 10, 2019
Merged

Added Longest Palindromic Substring in Python#1214
jrg94 merged 11 commits intoTheRenegadeCoder:masterTheRenegadeCoder/sample-programs:masterfrom
PaulSayantan:masterCopy head branch name to clipboard

Conversation

@PaulSayantan
Copy link
Contributor

@PaulSayantan PaulSayantan commented Oct 8, 2019

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder! For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

  • I fixed #your-issue-number-here

Code Snippets

  • I named the pull request using Added/Updated <Sample Program> in <Language> format
  • I created/updated the language README
    • I added the sample program name to the README
    • I added fun facts (i.e. debut, developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

Documentation

  • I named the pull request using Added/Updated <Sample Program> in <Language> Article format
  • I followed the applicable article template

Testing

  • I named the pull request using Added/Updated <Language>/<Project> Testing format
  • I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

ImgBotApp and others added 2 commits October 8, 2019 14:21
/docs/assets/images/fizz-buzz.png -- 417.11kb -> 370.70kb (11.13%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
@jrg94 jrg94 requested a review from a team October 8, 2019 17:05
@jrg94 jrg94 self-assigned this Oct 8, 2019
@jrg94 jrg94 added enhancement Any code that improves the repo hacktoberfest Hacktoberfest related labels Oct 8, 2019
@jrg94 jrg94 added this to the 500 Code Snippets milestone Oct 8, 2019
@jrg94
Copy link
Member

jrg94 commented Oct 8, 2019

Hey @belikesayantan! We currently don't support this project. Any chance you'd want to put together the documentation for it? See projects.

@PaulSayantan
Copy link
Contributor Author

Hey @jrg94, added Documentation for the python script. Please Review
#1214

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you update this to include a reference to this program in the language README. In addition, can you more closely follow the template for the index file. It looks great so far!

docs/projects/longest-palindrome-substring/index.md Outdated Show resolved Hide resolved
@PaulSayantan
Copy link
Contributor Author

PaulSayantan commented Oct 10, 2019

Hey, @jrg94, added requirements in documentation
also, updated README.md
Review

PaulSayantan and others added 2 commits October 10, 2019 15:48
Moved example to description section to conform to template.
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved some things around, so the file conforms more closely to our template. Now, I think it's good to go. Feel free to let me know otherwise!

@PaulSayantan
Copy link
Contributor Author

It's alright. You can merge it #1214

@PaulSayantan PaulSayantan requested a review from jrg94 October 10, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Any code that improves the repo hacktoberfest Hacktoberfest related

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.