added-ModularArithmetic-code#1217
Merged
raklaptudirm merged 3 commits intoTheAlgorithms:masterTheAlgorithms/JavaScript:masterfrom Oct 20, 2022
hiitesh1127:hiitesh1127-patch-5hiitesh1127/JavaScript:hiitesh1127-patch-5Copy head branch name to clipboard
Merged
added-ModularArithmetic-code#1217raklaptudirm merged 3 commits intoTheAlgorithms:masterTheAlgorithms/JavaScript:masterfrom hiitesh1127:hiitesh1127-patch-5hiitesh1127/JavaScript:hiitesh1127-patch-5Copy head branch name to clipboard
raklaptudirm merged 3 commits intoTheAlgorithms:masterTheAlgorithms/JavaScript:masterfrom
hiitesh1127:hiitesh1127-patch-5hiitesh1127/JavaScript:hiitesh1127-patch-5Copy head branch name to clipboard
Conversation
appgurueu
requested changes
Oct 19, 2022
Collaborator
There was a problem hiding this comment.
The modulus should not be hardcoded. Rather this should be a class (something like "ModRing"…) instantiated using the modulus (new ModRing(modulus)) providing the modular arithmetic operations as methods (ring.add(a, b)).
Alternatively you could consider a class ModRingNumber with a constructor taking num, mod params and the methods performing modular arithmetic after asserting that the mods of the numbers match.
Contributor
Author
|
Thank you Sir for your suggestions |
Contributor
Author
|
Sir Please review @raklaptudirm |
appgurueu
approved these changes
Oct 20, 2022
raklaptudirm
approved these changes
Oct 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.