Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add an algorithm to find length of an arc and area of the sector formed by an arc of a circle #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raklaptudirm merged 6 commits into from
Oct 8, 2022
Merged

Add an algorithm to find length of an arc and area of the sector formed by an arc of a circle #1119

raklaptudirm merged 6 commits into from
Oct 8, 2022

Conversation

@prashalruchiranga
Copy link
Contributor

@prashalruchiranga prashalruchiranga commented Oct 3, 2022

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu previously approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough that it doesn't need tests.

@appgurueu appgurueu added the algorithm Adds or improves an algorithm label Oct 3, 2022
appgurueu
appgurueu reviewed Oct 3, 2022
View reviewed changes
Maths/CircularArc.js Outdated Show resolved Hide resolved
appgurueu
appgurueu reviewed Oct 3, 2022
View reviewed changes
Maths/CircularArc.js Outdated Show resolved Hide resolved
appgurueu
appgurueu previously approved these changes Oct 3, 2022
View reviewed changes
appgurueu
appgurueu previously approved these changes Oct 3, 2022
View reviewed changes
@prashalruchiranga
Copy link
Contributor Author

prashalruchiranga commented Oct 6, 2022

@raklaptudirm Can you review this?

raklaptudirm
raklaptudirm requested changes Oct 7, 2022
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Degrees to Radians is also an useful algorithm. Put it in a separate file and export it. Also add tests for it.

@prashalruchiranga
Copy link
Contributor Author

prashalruchiranga commented Oct 7, 2022

@raklaptudirm I have exported the Degrees to Radians function from an already available file and added tests as you requested.

appgurueu
appgurueu reviewed Oct 7, 2022
View reviewed changes
Maths/test/CircularArc.test.js Outdated Show resolved Hide resolved
@raklaptudirm raklaptudirm merged commit 109e4a6 into TheAlgorithms:master Oct 8, 2022
@prashalruchiranga prashalruchiranga deleted the prashal-1 branch October 10, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

algorithm Adds or improves an algorithm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prashalruchiranga @appgurueu @raklaptudirm
Morty Proxy This is a proxified and sanitized view of the page, visit original site.