Add javadoc comments and Cleanup DynamicArray.java #1396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@StepfenShawn Could you kindly review this? |
StepfenShawn
approved these changes
Aug 13, 2020
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javadoc comments allow the user to understand the purpose of each method within the DynamicArray class.
cleanup within the class covers:
Condense imports
Initialize fields in constructor
Change binary shifting to simple multiplication reassignment for better understanding
Add brackets to multi-line if statements
Change name of size() method to getSize() to reflect purpose of the method
remove extra white-space
remove 2 lines of unnecessary commented out code
closes #1400