remove default zero(UInt) from hash seed #141
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 96.67% 96.84% +0.17%
==========================================
Files 30 30
Lines 2614 2602 -12
==========================================
- Hits 2527 2520 -7
+ Misses 87 82 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks. Other issues seem to be related to Julia 1.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this creates a 1-arg method
Base.hash(:: AbstractExpressionNode{T})morespecific than the defaulthash(::Any)fallback, and since the default seed is not0anymore this leads to hash inconsistencies and bugs.