-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[2.1] [Maintenance] adjust translation guide in github issue template config #18404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.1
Are you sure you want to change the base?
[2.1] [Maintenance] adjust translation guide in github issue template config #18404
Conversation
WalkthroughUpdated the GitHub issue template config to replace the 🇺🇸 Translations contact link with a 🌍 UI Translations contact link, including a new URL and description. No other structural or behavioral changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Check https://github.com/Sylius/Sylius/actions/runs/18138384288 for details. Available commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/ISSUE_TEMPLATE/config.yml (1)
12-14
: Simplify the UI Translations description to avoid URL duplication.The
about
field currently repeats the URL already set on line 13. Align it with other links by mentioning the guide text first and placing the URL once in backticks:- about: Have a look at `https://docs.sylius.com/the-book/contributing/contributing-translations` to read more about how you can contribute translations to Sylius. + about: To contribute translations to Sylius, see the guide at `https://docs.sylius.com/the-book/contributing/contributing-translations`
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/ISSUE_TEMPLATE/config.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Static checks / PHP 8.4, Symfony ^7.3
- GitHub Check: Static checks / PHP 8.3, Symfony ^7.3
- GitHub Check: Static checks / PHP 8.2, Symfony ^6.4
I noticed that the URL
translate.sylius.com
wasnt working anymore. So i adjusted the title, url, and description with the latest informations on how to contribute translations to sylius.Summary by CodeRabbit