Fix zip step in build-and-release.yml#19
Merged
albertodebortoli merged 1 commit intomasterStellarTools/Stellar:masterfrom Jan 23, 2023
feature/fix-release-zip-contentStellarTools/Stellar:feature/fix-release-zip-contentCopy head branch name to clipboard
Merged
Fix zip step in build-and-release.yml#19albertodebortoli merged 1 commit intomasterStellarTools/Stellar:masterfrom feature/fix-release-zip-contentStellarTools/Stellar:feature/fix-release-zip-contentCopy head branch name to clipboard
albertodebortoli merged 1 commit intomasterStellarTools/Stellar:masterfrom
feature/fix-release-zip-contentStellarTools/Stellar:feature/fix-release-zip-contentCopy head branch name to clipboard
Conversation
xl4kj
approved these changes
Jan 22, 2023
malcommac
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release zip was created with missing files deeper than 2 levels, only reproducible on GitHub Actions.
It seriously looks to me like a bug in
zip, as the**glob is very much Linux standard, andzipis the same version locally and remotely (v3.0.0).I'm now using the
-rparameter to recursively zip all files.Go figure!