Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

AMR: use RESP3 and disable the default config channel by default#3067

Open
mgravell wants to merge 13 commits intomainStackExchange/StackExchange.Redis:mainfrom
marc/resp3_amrStackExchange/StackExchange.Redis:marc/resp3_amrCopy head branch name to clipboard
Open

AMR: use RESP3 and disable the default config channel by default#3067
mgravell wants to merge 13 commits intomainStackExchange/StackExchange.Redis:mainfrom
marc/resp3_amrStackExchange/StackExchange.Redis:marc/resp3_amrCopy head branch name to clipboard

Conversation

@mgravell
Copy link
Copy Markdown
Collaborator

@mgravell mgravell commented Apr 28, 2026

@philon-msft

Specific to AMR endpoints for now (planned more generally for v3)

  • prefer RESP3
  • don't use the old booksleeve pub/sub channel
  • don't run the post-connect maintenance listener hook

Unit test validates behaviour. As a side change: the toy server now supports TLS so we can emulate AMR as closely as possible; we use a self-signed cert for this.

Outstanding:

  • pub/sub connections are too eager - need to make lazier, so that even on RESP2 with booksleeve channel disabled:
    1. pub/sub doesn't connect initially
    2. but it does connect when needed

@mgravell mgravell requested a review from philon-msft April 28, 2026 12:21
Comment thread src/StackExchange.Redis/Configuration/DefaultOptionsProvider.cs
Comment thread src/StackExchange.Redis/PublicAPI/PublicAPI.Unshipped.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.