-
Notifications
You must be signed in to change notification settings - Fork 0
MMA-3573. Update from upstream #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add typecheck to `_mysql.result()`
using homebrew
- Based on PyMySQL#106 but now disabled by default - Can be enabled via 'binary_prefix' connection parameter - Added unit tests to verify behaviour
* set mysql password * add mysql to services
Random fail happens on container based image.
GPL-2.0 was removed in b6601fe
Don't touch MYSQL.reconnect directly.
Since Connections.encoders is broken by design. Tuple and list is escaped directly in `Connection.literal()`. Removed tuple and list from converters mapping. Fixes PyMySQL#145
Before *Most* string fields were passed to custom converter functions as "bytes", everything else was assumed to be valid encoded utf-8 and passed as str. This could cause issues where some unknown field was not valid utf-8 and a decode error is triggered where it can't be fixed or avoided by the end user. Instead we should short list those fields that we know for sure have to be str type because the existing converters expect it to be that way. So all the date conversions, and (NEW)DECIMAL since the python decimal type will not accept bytes object. Everything else stays bytes, which is the least suprising and safest thing to do.
Users of gc.get_referrers() could cause a SystemError to be raised if this function is running in a different python thread.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is just a fetch and merge from upstream? Nothing I can really review in that case, QA needs to handle making sure all works fine still.
@@ -44,26 +19,22 @@ classifiers: | ||
Operating System :: Unix | ||
Programming Language :: C | ||
Programming Language :: Python | ||
Programming Language :: Python :: 2 | ||
Programming Language :: Python :: 2.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like an issue? Unless we are not planning to update until the Py3 project is done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that for our own needs we'll publish the last compatible tags in version branches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I talked with kostas we can release from the tag v.1.4.0 which solves our compatibility issues with debian buster.
We need to release tag v1.4.0 which is compatible with debian buster.