Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add JS/TS configuration #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2023
Merged

Add JS/TS configuration #32

merged 1 commit into from
May 4, 2023

Conversation

lucas-paulger-sonarsource
Copy link
Contributor

Ismail and I ran into some configuration needs when setting up IntelliJ to run the web project.

ismailcherri
ismailcherri approved these changes Apr 19, 2023
View reviewed changes
Copy link

@ismailcherri ismailcherri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@antonio-garcia-sonarsource
Copy link

There's actually a solution for Prettier that doesn't require a plugin and it is what I am using. Did you consider it? I am trying the plugin now to see how it compares

image

@lucas-paulger-sonarsource
Copy link
Contributor Author

There's actually a solution for Prettier that doesn't require a plugin and it is what I am using. Did you consider it? I am trying the plugin now to see how it compares

Let me know what you think, I did not try the non-plugin route.

@ismailcherri
Copy link

There's actually a solution for Prettier that doesn't require a plugin and it is what I am using. Did you consider it? I am trying the plugin now to see how it compares

I prefer the plugin approach because it is easier to setup

@gregaubert
Copy link
Member

Looks good from my point of view! It might be worth pinging SQ, SonarLint or JS/TS bubble to know if any of them are also using IntelliJ and get their opinion on the config

@lucas-paulger-sonarsource lucas-paulger-sonarsource merged commit 05a361e into master May 4, 2023
@lucas-paulger-sonarsource lucas-paulger-sonarsource deleted the feature/lp/add-js-ts-config branch May 4, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ismailcherri ismailcherri ismailcherri approved these changes

@gregaubert gregaubert Awaiting requested review from gregaubert

@andreyluiz andreyluiz Awaiting requested review from andreyluiz

@nicolas-gouteux-sonarsource nicolas-gouteux-sonarsource Awaiting requested review from nicolas-gouteux-sonarsource

@antonio-garcia-sonarsource antonio-garcia-sonarsource Awaiting requested review from antonio-garcia-sonarsource

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lucas-paulger-sonarsource @antonio-garcia-sonarsource @ismailcherri @gregaubert
Morty Proxy This is a proxified and sanitized view of the page, visit original site.