This repository was archived by the owner on Aug 27, 2022. It is now read-only.
Fixed Antigravity Bubbles #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sefiraat
reviewed
Mar 31, 2022
src/main/java/me/profelements/dynatech/items/electric/AntigravityBubble.java
Outdated
Show resolved
Hide resolved
Sefiraat
reviewed
Mar 31, 2022
Sefiraat
reviewed
Mar 31, 2022
src/main/java/me/profelements/dynatech/tasks/AntigravityBubbleTask.java
Outdated
Show resolved
Hide resolved
Sefiraat
reviewed
Mar 31, 2022
src/main/java/me/profelements/dynatech/items/electric/AntigravityBubble.java
Show resolved
Hide resolved
Sefiraat
reviewed
Mar 31, 2022
src/main/java/me/profelements/dynatech/items/electric/AntigravityBubble.java
Show resolved
Hide resolved
Author
|
Hey @Sefiraat , I did not know blocks could share variables (I didn't know what static variables did). I have applied your feedback. I got rid of the AntigravityBubbleTask and do everything in the AntigravityBubble itself now. I tested it with 3 Minecraft accounts (I'm never going to financially recover from this) and it all seems to work perfectly. |
Sefiraat
reviewed
Apr 1, 2022
src/main/java/me/profelements/dynatech/items/electric/AntigravityBubble.java
Outdated
Show resolved
Hide resolved
src/main/java/me/profelements/dynatech/items/electric/AntigravityBubble.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| private void checkPlayer(UUID u) { |
Member
There was a problem hiding this comment.
Ill look at this method when I'm back at my PC tomorrow and also give this a good general test
Author
|
The energy consumption works properly now, I implemented the rest and everything seems to work perfectly (tested with 2 players in one bubble, 1 in another further away). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a week of work, I finally managed to fix antigravity bubbles.
Current problem with them:
Each bubble checks what entities are in it's range on their own and they don't do it fully synchronized, due to this you are unable to fly if you have 2 antigravity bubbles out of each other's range.
How I fixed it:
Mostly all the antigravity bubbles do now for giving players flight-side is sending their block location to a task. This task is a SyncRepeatingTask from Bukkit that now gets executed every 60 ticks or 3 seconds (change this if it's too quick), every bubble location is stored in this class and deleted when the block is removed and every 3 seconds it will check the entities in a range for all the bubble locations. Doing this makes checking entities to give flight synchronized and actually function.
I do not know if my fix is proper coding, I learned Java on the go here, but at least they work now. Have fun!