Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@eygwi
Copy link

@eygwi eygwi commented Dec 16, 2025

Description

This PR fixes a bug regarding the Pickaxe of the Vein Mining. Previously, when this tool was enchanted with Fortune, the drops were not calculated correctly (the Fortune effect was ignored or inconsistent) during the vein mining operation.

Proposed changes

I have updated the logic for the Pickaxe of the Vein Mining to ensure that the Fortune enchantment is correctly applied to the drops.
Now, when using the Vein Mining ability, the drops will correctly reflect the Fortune level on the pickaxe, matching the expected behavior.

Before Fix
https://jumpshare.com/s/mQ2ijJOYAO8CfugdvTHV

After Fix
https://jumpshare.com/s/fIlEzieY2bKTu1z8aPB6

Related Issues (if applicable)

Resolves #4304

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@eygwi eygwi requested a review from a team as a code owner December 16, 2025 02:59
@github-actions
Copy link
Contributor

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VeinMiner pickaxe applies fortune incorrectly to ores.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.