Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: add support for php 8.1 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2022
Merged

feat: add support for php 8.1 #28

merged 2 commits into from
Aug 16, 2022

Conversation

jmauerhan
Copy link
Contributor

@jmauerhan jmauerhan commented Aug 16, 2022 •
edited
Loading

Proposed changes

  • Add support for PHP 8.1
  • Requires updating PHP Unit

How to test

  • Tested locally using 7.4.26, and 8.1.8 - both versions allowed vendor install and tests run and pass.

Unit Tests

  • This PR has unit tests
  • This PR does not have unit tests: used existing tests

@jmauerhan jmauerhan marked this pull request as ready for review August 16, 2022 16:04
@jmauerhan jmauerhan requested review from cberube, maccath and xiian August 16, 2022 16:08
@jmauerhan jmauerhan merged commit f3e647e into main Aug 16, 2022
@jmauerhan jmauerhan deleted the feat-8.1-support branch August 16, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiian xiian xiian approved these changes

@cberube cberube cberube approved these changes

@maccath maccath Awaiting requested review from maccath

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmauerhan @xiian @cberube
Morty Proxy This is a proxified and sanitized view of the page, visit original site.