fix: remove entity typename = ref typename #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…because they fail without entity object having an typename
xiian
previously approved these changes
Aug 30, 2021
jmauerhan
suggested changes
Aug 30, 2021
test/SchemaTest.php
Outdated
| @@ -81,66 +81,5 @@ public function testSchemaSdl() | ||
|
|
||
| $this->assertMatchesSnapshot($schemaSdl); | ||
| } | ||
|
|
||
| public function testResolvingEntityReferences() |
There was a problem hiding this comment.
I don't think we should remove the entire test, just adjust it to handle the change
jeffreybaird
approved these changes
Aug 31, 2021
|
@tarekul don't forget to bump this in skillshare as part of your Class/ClassLesson fixes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
How to test
Unit Tests