Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: make reference resolver public #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2021
Merged

fix: make reference resolver public #15

merged 1 commit into from
Apr 22, 2021

Conversation

jeffreybaird
Copy link
Contributor

Proposed changes

  • When resolving a federated type, we need to be able to overwrite the referenceResolver function which sets the referenceResolver property.
  • This was mistakenly removed from the previous PR

How to test

Unit Tests

  • This PR has unit tests
  • This PR does not have unit tests: why?

@MattYY MattYY self-requested a review April 22, 2021 14:18
@MattYY MattYY requested a review from ldiego08 April 22, 2021 14:18
@jeffreybaird jeffreybaird changed the title Make reference resolver public fix: make reference resolver public Apr 22, 2021
@jeffreybaird jeffreybaird merged commit 1c2bf7b into master Apr 22, 2021
@jeffreybaird jeffreybaird deleted the make-reference-resolver-public branch April 22, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldiego08 ldiego08 ldiego08 approved these changes

@MattYY MattYY MattYY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffreybaird @ldiego08 @MattYY
Morty Proxy This is a proxified and sanitized view of the page, visit original site.