Fixed active page in pager highlighting issue#2670
Closed
vmilev wants to merge 1 commit intoSitefinity:masterSitefinity/feather:masterfrom
Closed
Fixed active page in pager highlighting issue#2670vmilev wants to merge 1 commit intoSitefinity:masterSitefinity/feather:masterfrom
vmilev wants to merge 1 commit intoSitefinity:masterSitefinity/feather:masterfrom
Conversation
…/selected page when the page range is different from 0-10. For example when the range is 10-20 active page is not highlighted.
|
Hi @vmilev When is planning on being released? We have the same issue where the "Model.CurrentPage" doesn't actually return the correct value for pages after 10. Page 11 returns 1 Is the above also a fix for this? |
Author
|
@elivnjak Yes, this should work too, since my pull request is just a more proper fix for this commit: 335bd64 However, I have no idea if the sitefinity team will accept my pull request. Perhaps @atanas-georgiev can share some more info. |
Contributor
|
Hi Vladimir, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue with the pager where it wouldn't highlight the current/selected page when the page range is different from 0-10. For example when the range is 10-20 active page is not highlighted.