Dispose of ctypes to fix np.array holding on to memory for too long (fixes #108) #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also pushed a unit test that fails without this fix but passes with it. Didn't include in PR because it's possibly flaky due to how it tests RAM usage. You can see it here and I can add it to this PR if you think it's suitable. |
ok, sure, please add it. if it turns out too flaky I can still uncomment it, but it is still nice to have it. |
|
@henon nice, pushed. |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure why
ctypesrequires explicit disposal but tests show this to be the case.It is not possible to work-around this issue by calling
array.ctypes.Dispose(); it probably creates a whole extra reference and only that gets disposed.This is also why this PR stores
ctypesin a local: getting it again via eitherndarray.ctypesorndarray.PyObject.ctypesjust to dispose of it does not work.fix #108