Implement Adjoints for solution of IntervalNonlinearProblems #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
15
to
16
| !is_extension_loaded(Val(:DiffEqBase)) && | ||
| error("Adjoint sensitivity analysis requires `DiffEqBase.jl` to be explicitly loaded.") |
There was a problem hiding this comment.
why is this needed? This seems very unncessary
There was a problem hiding this comment.
So without DiffEqBase being loaded Zygote tries to differentiate through the IntervalNonlinearProblem constructor.
There was a problem hiding this comment.
Just make it an extension in SciMLBase
There was a problem hiding this comment.
As in an actual SciMLBaseBracketingNonlinearSolveExt in SciMLBase, yes?
There was a problem hiding this comment.
No just chainrules for the constructor rules
There was a problem hiding this comment.
Oh I see what you're saying now. I'll add the constructor rrules to the SciMLBase chain rules extension.
| prob::IntervalNonlinearProblem, | ||
| sensealg, p, alg, args...; kwargs... | ||
| ) | ||
| # DiffEqBase is needed for problem/function constructor adjoint |
There was a problem hiding this comment.
These should just be SciMLBase extensions.
|
|
||
| [extensions] | ||
| BracketingNonlinearSolveForwardDiffExt = "ForwardDiff" | ||
| BracketingNonlinearSolveChainRulesCoreExt = "ChainRulesCore" | ||
| BracketingNonlinearSolveChainRulesCoreExt = ["ChainRulesCore", "Zygote"] |
ad0ba38 to
789e04b
Compare
lib/BracketingNonlinearSolve/ext/BracketingNonlinearSolveChainRulesCoreExt.jl
Outdated
Show resolved
Hide resolved
ChrisRackauckas
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
@ChrisRackauckas this should work in a similar way to the SimpleNonlinearSolve adjoints. It works and gives the correct answer if I define the rrule in the REPL, but the extension with the rrule doesn't seem to actually load. I haven't dealt with extensions much so I think I'm missing something.