Fix IndexError#26
Open
margaritaG wants to merge 1 commit intoScanNet:masterScanNet/ScanNet:masterfrom
margaritaG:fix/fix_index_errormargaritaG/ScanNet:fix/fix_index_errorCopy head branch name to clipboard
Open
Fix IndexError#26margaritaG wants to merge 1 commit intoScanNet:masterScanNet/ScanNet:masterfrom margaritaG:fix/fix_index_errormargaritaG/ScanNet:fix/fix_index_errorCopy head branch name to clipboard
margaritaG wants to merge 1 commit intoScanNet:masterScanNet/ScanNet:masterfrom
margaritaG:fix/fix_index_errormargaritaG/ScanNet:fix/fix_index_errorCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There exists one execution path that results in an
IndexError, this fix solves it.Specifically, whenever we evaluate a single scan which contains a match
mthat bothhas_gtandhas_pred, in which all predictions are non-matched but also all of them are ignored and not counted as FP, theny_trueand consequentlyy_true_sorted_cumsumare empty arrays.Then accessing
y_true_sorted_cumsum[-1]results in an IndexError.