Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@sisoje
Copy link

@sisoje sisoje commented Oct 18, 2022

No description provided.

@adamgit
Copy link
Contributor

adamgit commented Oct 19, 2022

This appears to simply remove all logging, and provide no replacement? (have I misread or misunderstood the suggested change here?)

If that's correct - are you volunteering to take on all incoming support requests? Every single person who makes the smallest mistake in their code, or has any problem -- can we give them your private email address for you to debug their code for them? You're removing their ability to solve their own problems.

@bstillitano
Copy link

@adamgit an attitude like that will kill your library. Perhaps you could've attempted to reason with @sisoje as to why the change is not appropriate and subsequently he could've made adjustments and found a suitable alternative.

As it stands, your library does not compile and his branch fixes that.

@bubudrc
Copy link

bubudrc commented Jan 5, 2023

maybe, we can change the external library of cocolumberjack and use the apple support of OSLog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.