Efficient FFI loading #71
Merged
jorgemarpa merged 26 commits intoSSDataLab:masterSSDataLab/psfmachine:masterfrom Jun 9, 2023
Merged
Efficient FFI loading #71jorgemarpa merged 26 commits intoSSDataLab:masterSSDataLab/psfmachine:masterfrom
jorgemarpa merged 26 commits intoSSDataLab:masterSSDataLab/psfmachine:masterfrom
Conversation
1 task
jorgemarpa
commented
Jun 8, 2023
jorgemarpa
commented
Jun 9, 2023
Contributor
Author
jorgemarpa
left a comment
There was a problem hiding this comment.
Need to run demo notebooks to check consistent results
jorgemarpa
commented
Jun 9, 2023
Contributor
Author
jorgemarpa
left a comment
There was a problem hiding this comment.
flake8 passing
jorgemarpa
commented
Jun 9, 2023
Contributor
Author
jorgemarpa
left a comment
There was a problem hiding this comment.
flake8 passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the FFI loading methods to be more memory efficient plus other minor changes.
Changes:
fitsioand reading only the asked dataffi.load_from_file()andtpf.from_TPFS()both accept the keywordsourcesfor custom user input.ffi.flux_2dis a property useful for plotting functionsmachine.source_maskandmachine.uncontaminated_pixel_maskdist_lim-->sparse_dist_limasmachineattribute so it can be modified depending on instrument pixel scale (e.g. TESS)time_correctorwas deprecated andPerturbationhandles thismachine.sources_flux_columnto designate globally which column from thesourcecatalog will be used as flux estimate. This update is necessary for TESS which uses the R band instead of G.plot_shape_model()has flexible radii and color mapping stretch from flux percentiles. This is useful for other instruments (TESS)