Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Aug 15, 2024. It is now read-only.

Comments

Close side panel

Bug When Reading Stream Backwards#120

Merged
damianh merged 2 commits intoSQLStreamStore:masterSQLStreamStore/SQLStreamStore:masterfrom
thefringeninja:range-of-outthefringeninja/SQLStreamStore:range-of-outCopy head branch name to clipboard
May 2, 2018
Merged

Bug When Reading Stream Backwards#120
damianh merged 2 commits intoSQLStreamStore:masterSQLStreamStore/SQLStreamStore:masterfrom
thefringeninja:range-of-outthefringeninja/SQLStreamStore:range-of-outCopy head branch name to clipboard

Conversation

@thefringeninja
Copy link
Contributor

@thefringeninja thefringeninja commented May 2, 2018

When you read a stream backwards starting at a version that's beyond the end of the stream, the behavior is different depending on the implementation. Works as expected for MSSQL but throws an ArgumentOutOfRangeException for the In Memory implementation.

@thefringeninja thefringeninja force-pushed the range-of-out branch 2 times, most recently from 368f7a3 to 3647138 Compare May 2, 2018 12:06
@thefringeninja thefringeninja changed the title [WIP] Bug When Deleting Message Then Reading Stream [WIP] Bug When Reading Stream Backwards May 2, 2018
@thefringeninja thefringeninja changed the title [WIP] Bug When Reading Stream Backwards Bug When Reading Stream Backwards May 2, 2018
@damianh damianh added this to the v1.1.2 milestone May 2, 2018
@damianh damianh added the bug label May 2, 2018
@damianh damianh merged commit f7eef5c into SQLStreamStore:master May 2, 2018
@damianh damianh self-assigned this May 2, 2018
@thefringeninja thefringeninja deleted the range-of-out branch May 28, 2018 07:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.