This repository was archived by the owner on Aug 15, 2024. It is now read-only.
Allow overriding the way a SqlConnection is created#119
Merged
damianh merged 1 commit intoSQLStreamStore:masterSQLStreamStore/SQLStreamStore:masterfrom May 2, 2018
CumpsD:feature/provide-sqlconnection-factoryCopy head branch name to clipboard
Merged
Allow overriding the way a SqlConnection is created#119damianh merged 1 commit intoSQLStreamStore:masterSQLStreamStore/SQLStreamStore:masterfrom CumpsD:feature/provide-sqlconnection-factoryCopy head branch name to clipboard
damianh merged 1 commit intoSQLStreamStore:masterSQLStreamStore/SQLStreamStore:masterfrom
CumpsD:feature/provide-sqlconnection-factoryCopy head branch name to clipboard
Conversation
Member
|
Merged, thanks @CumpsD ! |
Contributor
Author
|
@damianh it took a while before I managed to use this in our codebase, and I realised, it would've been better to let it make a What do you think? Does it make sense to change this to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default a connection is still created using
new SqlConnection(connectionstring), except the user now has the ability to override this behavior.