Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Release 1.0.0#1

Merged
golluroSICKAG merged 10 commits into
SICKAppSpaceCodingStarterKit:mainSICKAppSpaceCodingStarterKit/CSK_Module_FlowConfig:mainfrom
golluroSICKAG:mainCopy head branch name to clipboard
Nov 28, 2024
Merged

Release 1.0.0#1
golluroSICKAG merged 10 commits into
SICKAppSpaceCodingStarterKit:mainSICKAppSpaceCodingStarterKit/CSK_Module_FlowConfig:mainfrom
golluroSICKAG:mainCopy head branch name to clipboard

Conversation

@golluroSICKAG

@golluroSICKAG golluroSICKAG commented Aug 14, 2024

Copy link
Copy Markdown
Contributor

Version 1.0.0

  • Initial version

Following tasks were checked

  • Module is coded and structured according to the "Developing guideline for modules" described within the CSK documentation
  • All functions/events/parameters are documented within the manifest documentation
  • The manifest description of the main CROWN includes main information about the purpose of the module and how to use it in general
  • API docu based on the manifest was created and stored within the "docu"-folder of the repository
  • Internal LUA code documentation exists for variables and non served functions
  • All relevant infos are logged via the SharedLogger 'ModuleLogger'
  • Module supports persistent data feature based on 'CSK_Module_PersistentData'
  • Module supports user management based on 'CSK_Module_UserManagement'
  • No open "ToDos" within the code or at least clearly explained comments why they exist...
  • "Version" key in app manifest was updated following semantic versioning (and use '0.x.y' for test / experimental modules which are not yet ready to be officially released)
  • Meaningful IDs used for UI elements
  • Module was tested on an AppSpace device (at least on SICK AppEngine) with no error message
  • README.md is up to date (incl. info of device + firmware the module was tested with)
  • CHANGELOG.md is up to date

@kogliinSICKAG kogliinSICKAG left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions in this review we already discussed but I left them in here.

Comment thread CSK_Module_FlowConfig/pages/CSK_Module_FlowConfig.msdd
Comment thread CSK_Module_FlowConfig/pages/assets/legacy/resources.json
Comment thread CSK_Module_FlowConfig/pages/CSK_Module_FlowConfig.msdd
Comment thread CSK_Module_FlowConfig/pages/CSK_Module_FlowConfig.msdd
Comment thread CSK_Module_FlowConfig/pages/CSK_Module_FlowConfig.msdd
Comment thread CSK_Module_FlowConfig/project.mf.xml Outdated
Comment thread CSK_Module_FlowConfig/pages/CSK_Module_FlowConfig.msdd
- Updated parameters of DemoFlows based on other module updates
- Check if all needed modules for selected DemoFlow are available
- Show information on UI reload per default (editable)
@golluroSICKAG golluroSICKAG merged commit 2030584 into SICKAppSpaceCodingStarterKit:main Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.