Replace direct use of once_cell to std #5627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the direct use of once_cell with the standard library's lazy primitives.
- Update once_cell::sync::Lazy to std::sync::LazyLock in multiple modules.
- Change OnceCell to OnceLock in the uuid module.
- Remove once_cell dependency from Cargo.toml files.
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vm/src/stdlib/sre.rs | Replaced once_cell usage with std::sync::LazyLock for mapping methods. |
| vm/src/builtins/weakproxy.rs | Updated Lazy to LazyLock for sequence methods. |
| vm/src/builtins/union.rs | Changed Lazy to LazyLock for mapping methods. |
| vm/src/builtins/tuple.rs | Replaced once_cell imports with std::sync::LazyLock for mapping and sequence methods. |
| vm/src/builtins/str.rs | Updated Lazy to LazyLock for mapping and sequence methods. |
| vm/src/builtins/set.rs | Replaced once_cell with std::sync::LazyLock for sequence methods. |
| vm/src/builtins/range.rs | Changed Lazy to LazyLock for both mapping and sequence methods. |
| vm/src/builtins/memory.rs | Replaced once_cell usage with std::sync::LazyLock in sequence methods. |
| vm/src/builtins/mappingproxy.rs | Updated Lazy to LazyLock for mapping and sequence methods. |
| vm/src/builtins/genericalias.rs | Changed Lazy to LazyLock for mapping methods. |
| vm/src/builtins/dict.rs | Replaced once_cell with std::sync::LazyLock in sequence methods. |
| vm/src/builtins/bytes.rs | Updated Lazy to LazyLock in mapping and sequence methods. |
| stdlib/src/uuid.rs | Replaced OnceCell with OnceLock for node ID caching. |
| stdlib/src/sqlite.rs | Changed once_cell::sync::Lazy to std::sync::LazyLock for mapping and sequence methods. |
| stdlib/src/mmap.rs | Replaced local once_cell usage with std::sync::LazyLock. |
| stdlib/src/csv.rs | Updated once_cell::sync::Lazy to std::sync::LazyLock in global static initialization. |
| stdlib/src/contextvars.rs | Changed once_cell to std::sync::LazyLock in sequence methods. |
| stdlib/Cargo.toml | Removed once_cell dependency. |
| derive-impl/src/compile_bytecode.rs | Updated once_cell::sync::Lazy to std::sync::LazyLock for manifest directory. |
| derive-impl/Cargo.toml | Removed once_cell dependency. |
coolreader18
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.