Apply nightly clippy suggestions #5625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR applies a series of nightly clippy suggestions across multiple modules to improve code clarity and safety.
- Refactors existing patterns (e.g., using Option::replace, is_empty, saturating_sub, repeat_n, and std::ptr::eq) to be more idiomatic and potentially safer.
- Simplifies code by removing unnecessary temporary variables and using more expressive standard library functions.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vm/src/stdlib/signal.rs | Uses Option::replace for more concise signal handler update. |
| vm/src/stdlib/itertools.rs | Refactors is_empty and repeat iterators for clarity. |
| vm/src/stdlib/ctypes/base.rs | Applies std::ptr::eq to compare pointers safely. |
| vm/src/frame.rs | Updates instruction matching to align with expected enum. |
| vm/src/builtins/tuple.rs | Simplifies tuple emptiness check. |
| vm/src/builtins/staticmethod.rs | Removes unnecessary variable assignment. |
| vm/src/builtins/range.rs | Uses saturating_sub for more robust length hint calculation. |
| vm/src/anystr.rs | Adopts repeat_n for clearer iteration over fill characters. |
| stdlib/src/csv.rs | Fixes slices acquisition for clarity and safety. |
| stdlib/src/binascii.rs | Uses div_ceil for a more reliable capacity calculation. |
| src/settings.rs | Improves string emptiness check via is_empty. |
| compiler/codegen/src/symboltable.rs | Uses Option::replace for cleaner class name update. |
| compiler/codegen/src/ir.rs | Streamlines location vector population with repeat_n. |
| compiler/codegen/src/compile.rs | Uses Option::replace to simplify class name assignment. |
| common/src/str.rs | Adopts repeat_n for a clearer zfill implementation. |
| common/src/boxvec.rs | Switches to std::ptr::eq for more explicit pointer comparison. |
coolreader18
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.