Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Remove winapi dependency and upgrade windows-sys to 0.59 #5581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 5, 2025
Merged

Remove winapi dependency and upgrade windows-sys to 0.59 #5581

merged 8 commits into from
Mar 5, 2025

Conversation

arihant2math
Copy link
Collaborator

@arihant2math arihant2math commented Mar 3, 2025 •
edited by youknowone
Loading

close #4078

youknowone
youknowone previously requested changes Mar 4, 2025
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! Now we can only have a single windows api source.

stdlib/src/socket.rs Outdated Show resolved Hide resolved
stdlib/src/socket.rs Outdated Show resolved Hide resolved
stdlib/src/socket.rs Outdated Show resolved Hide resolved
@arihant2math @youknowone
Update socket.rs
93c6933 
Co-authored-by: Jeong, YunWon <69878+youknowone@users.noreply.github.com>
@fanninpm
Copy link
Contributor

fanninpm commented Mar 4, 2025

cargo fmt should fix the error.

@arihant2math arihant2math changed the title Remove winapi dependency Remove winapi dependency and upgrade windows-sys to 0.59 Mar 5, 2025
@arihant2math arihant2math requested a review from youknowone March 5, 2025 18:52
coolreader18
coolreader18 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@coolreader18 coolreader18 merged commit d2bf317 into RustPython:main Mar 5, 2025
11 checks passed
@arihant2math arihant2math deleted the no-winapi branch March 5, 2025 19:52
@youknowone youknowone mentioned this pull request Mar 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

@youknowone youknowone Awaiting requested review from youknowone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch winapi to windows
4 participants
@arihant2math @fanninpm @youknowone @coolreader18
Morty Proxy This is a proxified and sanitized view of the page, visit original site.