Fix not throwing the same error as CPython in test_pathlib.test_expanduser #5578

hbina · Mar 2, 2025

Given,

hbina085@akarin-thinkpad ~/g/RustPython (main) [1]> cat ggg_nonexisten_user.py                                                                                                                                        (base) 
import pwd

fakename = 'fakeuser'
while pwd.getpwnam(fakename):
    fakename += '1'

Currently, in CPython,

hbina085@akarin-thinkpad ~/g/RustPython (main)> python ggg_nonexisten_user.py                                                                                                                                         (base) 
Traceback (most recent call last):
  File "/home/hbina085/git/RustPython/ggg_nonexisten_user.py", line 4, in <module>
    while pwd.getpwnam(fakename):
          ^^^^^^^^^^^^^^^^^^^^^^
KeyError: "getpwnam(): name not found: 'fakeuser'"

Whereas, in RustPython,

hbina085@akarin-thinkpad ~/g/RustPython (main) [1]> cargo run --release --quiet -- ggg_nonexisten_user.py                                                                                                             (base) 
Traceback (most recent call last):
  File "ggg_nonexisten_user.py", line 4, in <module>
    while pwd.getpwnam(fakename):
FileNotFoundError: (2, 'No such file or directory (os error 2)')

AFAIK, CPython doesn't care what kind of errors happen underneath.
See https://github.com/python/cpython/blob/a42168d316f0c9a4fc5658dab87682dc19054efb/Modules/pwdmodule.c#L270-L279

…of a non-existent user Signed-off-by: Hanif Ariffin <hanif.ariffin.4326@gmail.com>

youknowone · Mar 3, 2025

Thanks. If related tests don't exist in test_pwd, could you add the described test under extra_tests/snippets?

hbina · Mar 30, 2025

Not sure what other tests I can add tbh..

youknowone · Mar 31, 2025

@hbina I added a test file by copying the code you wrote. But when I ran the test on main branch, it didn't fail. That's maybe because I am on mac machine. Could you check if the test I added is failing without your patch on your machine, and add a commit message details that which environment causes that incompatibility?

extra_tests/snippets/stdlib_pwd.py

hbina · Apr 1, 2025

I tested it on a Ubuntu machine in my VirtualBox, the issue happens on the main branch.

I am not sure what you meant by which environment variables.

youknowone

Thank you for checking

…duser (RustPython#5578) * Fix not throwing the same error as CPython when trying to expanduser of a non-existent user Signed-off-by: Hanif Ariffin <hanif.ariffin.4326@gmail.com> * add pwd test * Skip pwd test on windows --------- Signed-off-by: Hanif Ariffin <hanif.ariffin.4326@gmail.com> Co-authored-by: Jeong YunWon <jeong@youknowone.org> Co-authored-by: Jeong, YunWon <69878+youknowone@users.noreply.github.com>

Fix not throwing the same error as CPython when trying to expanduser …

c7a8a69

…of a non-existent user Signed-off-by: Hanif Ariffin <hanif.ariffin.4326@gmail.com>

add pwd test

23aa15f

youknowone reviewed Mar 31, 2025

View reviewed changes

extra_tests/snippets/stdlib_pwd.py Show resolved Hide resolved

Skip pwd test on windows

4098989

youknowone approved these changes Apr 5, 2025

View reviewed changes

youknowone merged commit 2230d6c into RustPython:main Apr 5, 2025
11 checks passed

hbina deleted the hbina-fix-test-pathlib-test-expanduser branch April 5, 2025 08:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix not throwing the same error as CPython in test_pathlib.test_expanduser #5578

Fix not throwing the same error as CPython in test_pathlib.test_expanduser #5578

hbina commented Mar 2, 2025 •

edited

Loading

youknowone commented Mar 3, 2025

hbina commented Mar 30, 2025

youknowone commented Mar 31, 2025 •

edited

Loading

hbina commented Apr 1, 2025

youknowone left a comment

Search code, repositories, users, issues, pull requests...

Fix not throwing the same error as CPython in test_pathlib.test_expanduser #5578

Fix not throwing the same error as CPython in test_pathlib.test_expanduser #5578

Conversation

hbina commented Mar 2, 2025 • edited Loading

youknowone commented Mar 3, 2025

hbina commented Mar 30, 2025

youknowone commented Mar 31, 2025 • edited Loading

hbina commented Apr 1, 2025

youknowone left a comment

Choose a reason for hiding this comment

hbina commented Mar 2, 2025 •

edited

Loading

youknowone commented Mar 31, 2025 •

edited

Loading