clippy fix

Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
RustPython · youknowone · Mar 1, 2025 · Feb 28, 2025 · Feb 28, 2025 · Feb 28, 2025
commit 2c6e126498cb063d0aa47c441245b135f04bc251
diff --git a/vm/src/stdlib/ctypes/structure.rs b/vm/src/stdlib/ctypes/structure.rs
@@ -1,39 +1,44 @@
-use std::collections::HashMap;
 use crate::builtins::{PyList, PyStr, PyTuple, PyTypeRef};
 use crate::function::FuncArgs;
+use crate::types::GetAttr;
 use crate::{AsObject, Py, PyObjectRef, PyPayload, PyResult, VirtualMachine};
+use rustpython_common::lock::PyRwLock;
 use rustpython_vm::types::Constructor;
+use std::collections::HashMap;
 use std::fmt::Debug;
-use rustpython_common::lock::PyRwLock;
-use crate::types::GetAttr;

 #[pyclass(name = "Structure", module = "_ctypes")]
 #[derive(PyPayload, Debug)]
 pub struct PyCStructure {
+    #[allow(dead_code)]
    field_data: PyRwLock<HashMap<String, PyObjectRef>>,
-    data: PyRwLock<HashMap<String, PyObjectRef>>
+    data: PyRwLock<HashMap<String, PyObjectRef>>,
 }

 impl Constructor for PyCStructure {
    type Args = FuncArgs;

    fn py_new(cls: PyTypeRef, _args: Self::Args, vm: &VirtualMachine) -> PyResult {
-        let fields_attr = cls.get_class_attr(vm.ctx.interned_str("_fields_").unwrap()).ok_or_else(|| {
-            vm.new_attribute_error("Structure must have a _fields_ attribute".to_string())
-        })?;
+        let fields_attr = cls
+            .get_class_attr(vm.ctx.interned_str("_fields_").unwrap())
+            .ok_or_else(|| {
+                vm.new_attribute_error("Structure must have a _fields_ attribute".to_string())
+            })?;
        // downcast into list
        let fields = fields_attr.downcast_ref::<PyList>().ok_or_else(|| {
            vm.new_type_error("Structure _fields_ attribute must be a list".to_string())
        })?;
        let fields = fields.borrow_vec();
        let mut field_data = HashMap::new();
        for field in fields.iter() {
-            let field = field.downcast_ref::<PyTuple>().ok_or_else(|| {
-                vm.new_type_error("Field must be a tuple".to_string())
-            })?;
-            let name = field.get(0).unwrap().downcast_ref::<PyStr>().ok_or_else(|| {
-                vm.new_type_error("Field name must be a string".to_string())
-            })?;
+            let field = field
+                .downcast_ref::<PyTuple>()
+                .ok_or_else(|| vm.new_type_error("Field must be a tuple".to_string()))?;
+            let name = field
+                .get(0)
+                .unwrap()
+                .downcast_ref::<PyStr>()
+                .ok_or_else(|| vm.new_type_error("Field name must be a string".to_string()))?;
            let typ = field.get(1).unwrap().clone();
            field_data.insert(name.as_str().to_string(), typ);
        }
@@ -47,11 +52,10 @@ impl GetAttr for PyCStructure {
        let data = zelf.data.read();
        match data.get(&name) {
            Some(value) => Ok(value.clone()),
-            None => Err(vm.new_attribute_error(format!("No attribute named {}", name)))
+            None => Err(vm.new_attribute_error(format!("No attribute named {}", name))),
        }
    }
 }

 #[pyclass(flags(BASETYPE, IMMUTABLETYPE))]
 impl PyCStructure {}
-