Migrate to the 2024 edition #5560
Conversation
|
Everything was reformatted due to the 2024 upgrade. |
|
I might look to hold onto this until after #5561 merges, since they've been working on their patchset for a while and it seems like it'd be a pain to have to resolve formatting conflicts. |
|
It's annoying there's no way to switch to edition2024 while keeping the style edition on 2021, at least temporarily :/ |
|
Good catch on the stuff in |
That patch only has 2 changed files. Merging must not be painful. |
There was a problem hiding this comment.
Looks good to me. But if @coolreader18 worries, we can merge first commit without edition=2024 first, and do formatting later.
|
Yeah, you're right, it doesn't actually make any conflicts at all. Fix the conflict and this is good to go 👍 |
|
It's conflicting at the moment rather ironically. |
|
Setting the edition to 2021 doesn't change anything. I'll just resolve this conflict |
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
385ecb1 to
b870b0e
Compare
No description provided.