Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Enable rust2024-incompatible pat and keyword-ident lints #5559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

coolreader18
Copy link
Member

@coolreader18 coolreader18 commented Feb 25, 2025

Open to suggestions for a better "euphemism" for gen - could always just go with gen_ or even r#gen, but jen felt like it fit in the tradition of klass and zelf.

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel comfortable about gen, and maybe I chose a bit longer name like genor if I did. Otherwise zen because it is very frequently quoted in Python world.
But it may be just because I am not used to jen yet. No problem. Let's try.

@@ -3,7 +3,7 @@
//! This module makes use of the parser logic, and translates all ast nodes
//! into python ast.AST objects.

mod gen;
mod r#gen;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike variable names, we don't need shorten gen here.

@coolreader18 coolreader18 merged commit 864e859 into RustPython:main Feb 25, 2025
11 checks passed
@coolreader18 coolreader18 deleted the rust2024-incom_pat-and-kws branch February 25, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.