Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

winreg upgrade to 0.55 #5511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 17, 2025
Merged

Conversation

arihant2math
Copy link
Collaborator

No description provided.

@arihant2math arihant2math marked this pull request as draft February 10, 2025 22:30
@arihant2math arihant2math changed the title Windows-rs upgrade to 0.59 windows-rs upgrade to 0.59 Feb 17, 2025
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math arihant2math marked this pull request as ready for review February 17, 2025 06:45
@arihant2math
Copy link
Collaborator Author

I'm just going to let this merge as is. microsoft/windows-rs#3093 is turning out to be annoying to fix as every time an isize is passed in it wants a *mut cvoid instead.

For future reference, the "proper" way to do this (to my knowledge) is cast the isize to a cint, which can then be cast to the cvoid.

@arihant2math arihant2math changed the title windows-rs upgrade to 0.59 partial windows upgrade to 0.59 Feb 17, 2025
@arihant2math arihant2math changed the title partial windows upgrade to 0.59 partial windows tooling upgrade to 0.59 Feb 17, 2025
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math arihant2math changed the title partial windows tooling upgrade to 0.59 winreg upgrade to 0.55 Feb 17, 2025
Copy link
Member

@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after the clippy lint is fixed.

Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math
Copy link
Collaborator Author

Fixed.

@coolreader18 coolreader18 merged commit 517ffed into RustPython:main Feb 17, 2025
11 checks passed
@arihant2math arihant2math deleted the windows-upgrade branch February 17, 2025 23:36
@arihant2math arihant2math mentioned this pull request Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.