-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Pathconf names #4508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pathconf names #4508
Conversation
After CI completes, feel free to do a |
f1e488a
to
21072f9
Compare
I rebased it. |
Thanks -- I was looking at trying to do that but it didn't seem to look right as I still ended up with 2 additional changes -- I was thinking my baseline wasn't quite right or I did something incorrectly. |
I'm looking at the error -- I found an online free online macos simlulator and was able to get the error 22 manually trying the command os.pathconf('/',21) but that isn't conclusive. (pathconf worked for indexes 0-20). It looks like there are some platforms which may have pathconf indexes that are greater then 20 (e.g. in libc I suppose this is more a of libc specfic question does anyone know how can I tell which of the libc flavor will be used on macos/darwin? (and therefore which pathconf indexes value will show up in PathconfVar) Clarifying - As a result I suspect there may be a value in PathconVar which isn't valid for pathconf on that platform.... (and causing the error) The test could be simplified to only check a few manually selected values rather , but if this is actually I think it would be better to fix PathconfVar to have the correct values for the platform. |
ba0da32
to
8b09202
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to fix every macOS issue if if you don't have macOS machine. Please fill free to ask help if you have hard trouble to fix.
I think adding it only for linux is a working option now. I made a change about it. We can fix macOS issue later.
Thank you for contributing!
@@ -1881,6 +1883,24 @@ pub mod module { | ||
pathconf(PathOrFd::Fd(fd), name, vm) | ||
} | ||
|
||
// TODO: this is expected to be run on macOS as a unix, but somehow not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put linux cfg until it is fixed for macos
8b09202
to
955347e
Compare
Thank you for contributing! |
Thanks! |
Implementation for os.pathconf_names resolves #4494