Implement ascii codec in Rust #3118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec7ae7b to
20b86b2
Compare
Actually, I would like to make use of the error-handling code you have here. This can go first so I can rebase #3046 on top of your work. |
youknowone
reviewed
Sep 23, 2021
b4ffb51 to
ab04157
Compare
Co-authored-by: Jeong YunWon <youknowone@users.noreply.github.com>
ab04157 to
d869035
Compare
youknowone
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started on this at the beginning of June, so I figured I should finish it and get it in. A large part of the refactoring is just deduplicating decoding logic between utf8 and ascii, since in both the valid subset can just be
push_str()'d, and the rest passed to the error handler. The only difference is finding the invalid bytes, if any, and figuring out what the error is.