Use NDEBUG instead of _DEBUG so that debug / release detection is cross platform #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought about this for 2 minutes more, and I think a custom define is the only sane solution after all. I'll let you judge if you want to close or merge this. |
|
This seems reasonable - the compile options can be easily set by any end user of the library so adding a custom define seems unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on linux the "default" compilation config will run the release config even in debug, since _DEBUG is MSVC only.
This PR proposes switching to the
NDEBUGdefine, which is specified by the C / C++ standards, and thus should be cross platform.One minor caveat however is that it used to control asserts, and it can be defined or undefined independently of the actual compilation flags.
I don't know of any standard way to avoid this, so maybe a cleaner solution would be to pass a custom flag trough cmake or something like that, which is a little more complex than a one-line modification :P
In practice however, cmake (and most build systems) sets this flag when not in debug, and from my experience projects that have complex logic for handling which asserts to enable / disable opt for their own custom defines anyway, so I think this is acceptable.