This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Fixed and Improved some Japanese Translations#398
Open
Advizormcpe1 wants to merge 9 commits into
Open
Fixed and Improved some Japanese Translations#398Advizormcpe1 wants to merge 9 commits into
Advizormcpe1 wants to merge 9 commits into
Conversation
Rudloff
suggested changes
Mar 30, 2022
Owner
Rudloff
left a comment
There was a problem hiding this comment.
Thanks but can you please explain what was wrong with the previous translations and what exactly you fixed?
| "dist": { | ||
| "type": "zip", | ||
| "url": "https://github.com/ytdl-org/youtube-dl/archive/2021.04.01.zip" | ||
| "url": "https://github.com/ytdl-org/youtube-dl/archive/2021.06.06.zip" |
| #: templates/info.tpl:35 | ||
| msgid "Best" | ||
| msgstr "最高品質" | ||
| msgstr "最高品質(mp4形式)" |
Owner
There was a problem hiding this comment.
MP4 is not mentioned in the source string. (And choosing this option does not always guarantee an MP4 format.)
| #: templates/info.tpl:36 | ||
| msgid "Remux best video with best audio" | ||
| msgstr "最高品質に再エンコード" | ||
| msgstr "最高品質の音声と動画をmkvに再エンコード" |
Owner
There was a problem hiding this comment.
MKV is not mentioned in the source string.
If you think the format should be mentioned, please open an issue about this, but here is not the place to add it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.