feat: add "OFF" option to reasoning effort dropdown #8625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added "off" as a valid option in ReasoningEffortWithMinimal type - Updated ThinkingBudget component to show "off" option in dropdown - Modified shouldUseReasoningEffort to return false when set to "off" - Updated API transform logic to handle "off" value properly - Added translation for "off" option in English locale Fixes #8624
The OpenAI API types do not include "off" as a valid reasoning_effort value, so we need to exclude it similar to how we handle "minimal"
2 tasks
|
any updates? i see some checks failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #8624.
Summary
Added an "OFF" option to the reasoning effort dropdown to allow users to completely disable reasoning for models that support it, particularly for Deepseek v3.1 on OpenRouter.
Changes
Testing
Fixes #8624
Feedback and guidance are welcome!
Important
Add "OFF" option to reasoning effort dropdown, updating types, UI, API logic, and translations.
ReasoningEffortWithMinimaltype inmodel.ts.ThinkingBudgetcomponent to include "OFF" in dropdown.shouldUseReasoningEffortinapi.tsto return false for "OFF".reasoning.tsto handle "OFF" value.reasoning_effortAPI calls inrequesty.ts.settings.json.This description was created by
for 12bf42d. You can customize this summary. It will automatically update as commits are pushed.