fix: only include verbosity parameter for models that support it #7055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check supportsVerbosity flag before adding verbosity to API request - Prevents "Unrecognized request argument" errors when switching from GPT-5 to GPT-4.1 - Add tests to verify verbosity is excluded for unsupported models Fixes #7054
| // Add verbosity if supported | ||
| if (verbosity) { | ||
| // Add verbosity only if the model supports it | ||
| if (verbosity && model.info.supportsVerbosity) { |
There was a problem hiding this comment.
Good fix! This correctly checks for verbosity support before adding the parameter. However, could we add a brief comment here explaining why this check is necessary? Something like:
Suggested change
| if (verbosity && model.info.supportsVerbosity) { | |
| // Add verbosity only if the model supports it | |
| // GPT-5 family supports verbosity, but GPT-4.1 and other models don't | |
| if (verbosity && model.info.supportsVerbosity) { |
This would help future maintainers understand the reasoning behind this check.
| // Verify that verbosity is NOT included in the request | ||
| const callArgs = mockCreate.mock.calls[0][0] | ||
| expect(callArgs).not.toHaveProperty("verbosity") | ||
| expect(callArgs.model).toBe("gpt-4.1-mini") |
There was a problem hiding this comment.
Great test coverage for the main GPT-4.1 family models! Consider also adding a test case for gpt-4.1-nano to ensure complete coverage of all GPT-4.1 variants that don't support verbosity. This would make the test suite more comprehensive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #7054 where switching from GPT-5 models (which support the verbosity parameter) to GPT-4.1 or other models (which don't support it) causes API errors.
Problem
When a user sets verbosity while using GPT-5 models and then switches to GPT-4.1, the verbosity parameter is incorrectly passed to the API, resulting in:
400 Unrecognized request argument supplied: verbositywhen verbosity was set to Medium400 Unsupported value: 'verbosity' does not support 'low' with this modelwhen verbosity was set to Low or HighSolution
handleDefaultModelMessageinopenai-native.tsto check the model'ssupportsVerbosityflag before including the verbosity parameter in the API requestTesting
Changes
model.info.supportsVerbositybefore adding verbosity parameterFixes #7054
Important
Fixes verbosity parameter handling by checking model support before inclusion in
openai-native.ts, with tests added inopenai-native.spec.ts.Unrecognized request argument supplied: verbositywhen switching to another OpenAI model fromgpt-5-2025-08-07#7054 by modifyinghandleDefaultModelMessageinopenai-native.tsto checkmodel.info.supportsVerbositybefore including verbosity parameter.openai-native.spec.tsto ensure verbosity is excluded for unsupported models (gpt-4.1, gpt-4o, gpt-4.1-mini).openai-native.ts: Added check forsupportsVerbosity.openai-native.spec.ts: Added test cases for verbosity handling.This description was created by
for 51b1757. You can customize this summary. It will automatically update as commits are pushed.