Fix webview in dev mode #7044
Fix webview in dev mode #7044
Conversation
| @@ -0,0 +1,8 @@ | ||
| import { CloudUserInfo, OrganizationAllowList, ShareVisibility } from "@roo-code/cloud" |
There was a problem hiding this comment.
This file imports from @roo-code/cloud, but the PR removes this package from dependencies in package.json. This will cause a build failure since the package won't be available.
Is this intentional? If the goal is to fix the webview in dev mode, this approach will just move the error to a different location rather than fixing it.
Consider either:
- Keeping
@roo-code/cloudas a dependency if it's still needed - Or fully migrating these types to local definitions if the goal is to remove the external dependency
| "@radix-ui/react-slot": "^1.1.2", | ||
| "@radix-ui/react-tooltip": "^1.1.8", | ||
| "@roo-code/cloud": "^0.13.0", | ||
| "@roo-code/types": "workspace:^", |
There was a problem hiding this comment.
You're removing @roo-code/cloud from dependencies here, but the new src/shared/cloud.ts file still imports from this package. This seems contradictory and will cause the build to fail.
Could you clarify the intended approach? Are you trying to move the cloud package to a different location, or completely remove the dependency?
| } from "@roo-code/types" | ||
| import { type OrganizationAllowList, ORGANIZATION_ALLOW_ALL } from "@roo-code/cloud" | ||
|
|
||
| import { type OrganizationAllowList, ORGANIZATION_ALLOW_ALL } from "@roo/cloud" |
There was a problem hiding this comment.
The import path change from @roo-code/cloud to @roo/cloud looks good and follows the TypeScript path mapping. However, this will only work if the underlying dependency issue is resolved (see my comment on src/shared/cloud.ts).
Important
Fix webview in development mode by updating dependencies, imports, and build configurations.
@roo-code/clouddependency fromwebview-ui/package.json.knip.jsonto include../src/shared/*.tsinwebview-uiproject.@roo-code/cloudto@roo/cloudin multiple files includingAccountView.tsx,ShareButton.tsx, andApiConfigManager.tsx.@roo-code/cloudpackage linking fromlink-packages.js.cloud.tstosrc/shared/.vscode.tsmock fromwebview-ui/src/__mocks__/.external: ["vscode"]fromrollupOptionsinvite.config.ts.This description was created by
for 4d7b94f. You can customize this summary. It will automatically update as commits are pushed.