fix: disable reasoning budget UI controls for Claude Code provider (#5111) #5113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR disables reasoning budget UI controls for the Claude Code provider, preventing confusion from non-functional UI controls.
- Improved partial data handling and logging in streaming responses (run.ts)
- Disabled reasoning budget support in the Claude Code model definitions (claude-code.ts)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/integrations/claude-code/run.ts | Enhanced parsing of partial data with additional logging for debugging truncated messages. |
| packages/types/src/providers/claude-code.ts | Set supportsReasoningBudget and requiredReasoningBudget to false to align UI controls with provider capabilities. |
|
✅ No security or compliance issues detected. Reviewed everything up to 0068c43. Security Overview
Detected Code Changes
Reply to this PR with |
…Code provider (#5111) - Modified fallback logic in stream parsing to handle all message types, not just assistant messages - Added proper parsing attempts for partial data before yielding - Improved error logging to help debug streaming issues - Added debug logging (controlled by DEBUG_CLAUDE_CODE env var) to trace message types This ensures reasoning/thinking content from Claude 3.5 Sonnet 4.0 is properly displayed in all cases.
…5111) - Set supportsReasoningBudget to false for all Claude Code models - Claude Code CLI doesn't support thinking/reasoning parameters - UI controls were misleading users since they had no effect
- Add missing requiredReasoningBudget: false to claude-3-5-sonnet-20241022 and claude-3-5-haiku-20241022 - Revert run.ts changes as they are not needed for fixing the UI issue - The UI issue is resolved by properly disabling reasoning budget support in model configuration
…e into model selection
362b9f0 to
0068c43
Compare
mrubens
approved these changes
Jun 25, 2025
Alorse
pushed a commit
to Alorse/Roo-Code
that referenced
this pull request
Jun 27, 2025
…ooCodeInc#5111) (RooCodeInc#5113) * fix: resolve intermittent reasoning content not displayed for Claude Code provider (RooCodeInc#5111) - Modified fallback logic in stream parsing to handle all message types, not just assistant messages - Added proper parsing attempts for partial data before yielding - Improved error logging to help debug streaming issues - Added debug logging (controlled by DEBUG_CLAUDE_CODE env var) to trace message types This ensures reasoning/thinking content from Claude 3.5 Sonnet 4.0 is properly displayed in all cases. * fix: disable reasoning budget UI controls for Claude Code provider (RooCodeInc#5111) - Set supportsReasoningBudget to false for all Claude Code models - Claude Code CLI doesn't support thinking/reasoning parameters - UI controls were misleading users since they had no effect * fix: update Claude Code models configuration - Add missing requiredReasoningBudget: false to claude-3-5-sonnet-20241022 and claude-3-5-haiku-20241022 - Revert run.ts changes as they are not needed for fixing the UI issue - The UI issue is resolved by properly disabling reasoning budget support in model configuration * feat: add reasoning effort support to Claude Code models and integrate into model selection --------- Co-authored-by: Daniel Riccio <ricciodaniel98@gmail.com>
hannesrudolph
added a commit
that referenced
this pull request
Jul 3, 2025
…5111) (#5113) * fix: resolve intermittent reasoning content not displayed for Claude Code provider (#5111) - Modified fallback logic in stream parsing to handle all message types, not just assistant messages - Added proper parsing attempts for partial data before yielding - Improved error logging to help debug streaming issues - Added debug logging (controlled by DEBUG_CLAUDE_CODE env var) to trace message types This ensures reasoning/thinking content from Claude 3.5 Sonnet 4.0 is properly displayed in all cases. * fix: disable reasoning budget UI controls for Claude Code provider (#5111) - Set supportsReasoningBudget to false for all Claude Code models - Claude Code CLI doesn't support thinking/reasoning parameters - UI controls were misleading users since they had no effect * fix: update Claude Code models configuration - Add missing requiredReasoningBudget: false to claude-3-5-sonnet-20241022 and claude-3-5-haiku-20241022 - Revert run.ts changes as they are not needed for fixing the UI issue - The UI issue is resolved by properly disabling reasoning budget support in model configuration * feat: add reasoning effort support to Claude Code models and integrate into model selection --------- Co-authored-by: Daniel Riccio <ricciodaniel98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5111
This PR completes the fix for issue #5111 by disabling the reasoning budget UI controls for the Claude Code provider, which were misleading users since the Claude Code CLI doesn't support thinking/reasoning parameters.
Changes Made
supportsReasoningBudget: falsefor all Claude Code models inpackages/types/src/providers/claude-code.tsTesting
Verification of Acceptance Criteria
Checklist
Context
The Claude Code CLI uses a fixed
--output-format stream-jsonflag and doesn't support any parameters to control thinking/reasoning output. The UI was showing controls that had no effect, which was confusing for users. This change aligns the UI with the actual capabilities of the Claude Code provider.Important
Disables reasoning budget UI controls for Claude Code provider by setting
supportsReasoningBudget: falseinclaude-code.ts.supportsReasoningBudget: falseinclaude-code.ts.claude-sonnet-4-20250514,claude-opus-4-20250514,claude-3-7-sonnet-20250219,claude-3-5-sonnet-20241022,claude-3-5-haiku-20241022.This description was created by
for 0068c43. You can customize this summary. It will automatically update as commits are pushed.