fix: resolve claude-code provider image hang (#5100) #5105

hannesrudolph · Jun 25, 2025

Description

Resolves the issue where Roo Code hangs when users attempt to send images to the Claude Code provider. The root cause was a missing case in the useSelectedModel hook for the "claude-code" provider, which caused it to fall through to the default case and return incorrect model information.

Changes Made

Added missing "claude-code" case in useSelectedModel hook - The hook now properly handles the claude-code provider and returns the correct model information
Ensures proper model capabilities are reported - Claude Code models correctly report supportsImages: false
Prevents UI from allowing image uploads - The image input is now properly disabled when Claude Code provider is selected
Maintains consistency with other providers - Follows the same pattern as other provider cases in the switch statement

Testing

All existing tests pass (487 tests passed)
Specific tests for useSelectedModel hook pass (9 tests)
No linting errors
Type checking passes
Manual testing completed:
- Verified Claude Code provider selection works correctly
- Confirmed image input is disabled when Claude Code is selected
- Tested that other providers still work as expected

Verification of Acceptance Criteria

Application no longer hangs - Fixed by preventing image upload attempts to Claude Code
Image input properly disabled - The UI now correctly disables image input when Claude Code provider is selected
Clear user experience - Users can no longer attempt to send images to a provider that doesn't support them
No breaking changes - Other providers and functionality remain unaffected

Code Quality

Code follows project style guidelines
Self-review completed
Minimal, targeted fix that addresses the specific issue
No breaking changes
Maintains backward compatibility
Follow existing code patterns and conventions

Files Changed

webview-ui/src/components/ui/hooks/useSelectedModel.ts - Added claude-code case to properly return model info with supportsImages: false

Impact

Performance: No impact, minimal code change
Security: No security implications
User Experience: Significantly improved - eliminates hanging and provides proper UI state
Compatibility: Fully backward compatible

This fix implements the suggested solution from the issue description by preventing users from encountering the hanging issue when using the Claude Code provider.

Important

Fixes hanging issue with claude-code provider by updating useSelectedModel to handle it correctly and disable image support.

Behavior:
- Fixes hanging issue when sending images to claude-code provider by adding a missing case in useSelectedModel in useSelectedModel.ts.
- claude-code models now correctly report supportsImages: false.
- Disables image input in UI when claude-code is selected.
Testing:
- Added tests in useSelectedModel.spec.ts to verify claude-code behavior, including default model handling and image support.
Misc:
- Ensures consistency with other providers in the switch statement of getSelectedModel().

^{This description was created by}^{for 552e04e. You can customize this summary. It will automatically update as commits are pushed.}

- Add missing claude-code case in useSelectedModel hook - Ensures proper model info is returned with supportsImages: false - Prevents UI from allowing image uploads to claude-code provider - Fixes application hang when attempting to send images to claude-code

Copilot

Pull Request Overview

This PR fixes the hang issue when using the Claude Code provider by adding a missing case in the useSelectedModel hook. The changes include adding the claude-code case, importing the necessary default model ID and models, and ensuring proper model capabilities are returned so that image uploads are correctly disabled for the provider.

Added "claude-code" case in the useSelectedModel hook.
Imported claudeCodeDefaultModelId and claudeCodeModels to support the new case.
Returns the correct model information to disable image uploads.

webview-ui/src/components/ui/hooks/useSelectedModel.ts

delve-auditor · Jun 25, 2025

✅ No security or compliance issues detected. Reviewed everything up to 2bd3b91.

Security Overview

🔎 Scanned files: 2 changed file(s)

Detected Code Changes

Change Type	Relevant files
Enhancement	► useSelectedModel.spec.ts Add claude-code provider tests ► useSelectedModel.ts Add claude-code provider support

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

- Add comprehensive test cases for claude-code provider in useSelectedModel hook - Verify that claude-code models correctly report supportsImages: false - Test default model selection when no modelId is specified - Add inline documentation explaining claude-code's disabled features

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

daniel-lxs

Tested and it works.

LGTM

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Daniel <57051444+daniel-lxs@users.noreply.github.com>

…deInc#5105) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Daniel <57051444+daniel-lxs@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Daniel <57051444+daniel-lxs@users.noreply.github.com>

kaizendevsio · Aug 11, 2025

Can we not have the ability to paste pictures into roo code using the claude code provider? Isnt this possible? #5100 (comment)

Copilot AI review requested due to automatic review settings June 25, 2025 05:30

hannesrudolph requested review from cte, jr and mrubens as code owners June 25, 2025 05:30

github-project-automation bot added this to Roo Code Roadmap and Roo Code Roadmap Jun 25, 2025

github-project-automation bot moved this to New in Roo Code Roadmap Jun 25, 2025

github-project-automation bot moved this to Triage in Roo Code Roadmap Jun 25, 2025

dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jun 25, 2025

Copilot AI reviewed Jun 25, 2025

View reviewed changes

webview-ui/src/components/ui/hooks/useSelectedModel.ts Outdated Show resolved Hide resolved

hannesrudolph mentioned this pull request Jun 25, 2025

bug: Roo hangs when sending an image to the Claude Code provider #5100

Closed

hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 25, 2025

dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 25, 2025

daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jun 25, 2025

hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 25, 2025

Update webview-ui/src/components/ui/hooks/useSelectedModel.ts

2bd3b91

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

daniel-lxs approved these changes Jun 25, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 25, 2025

daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jun 25, 2025

hannesrudolph added PR - Needs Review and removed PR - Needs Preliminary Review labels Jun 25, 2025

mrubens approved these changes Jun 25, 2025

View reviewed changes

mrubens merged commit 83c19ce into main Jun 25, 2025
17 checks passed

mrubens deleted the fix/issue-5100-claude-code-image-hang branch June 25, 2025 20:08

github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 25, 2025

github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 25, 2025

daniel-lxs added a commit that referenced this pull request Jun 25, 2025

fix: resolve claude-code provider image hang (#5100) (#5105)

8c59c65

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Daniel <57051444+daniel-lxs@users.noreply.github.com>

hannesrudolph added a commit that referenced this pull request Jul 3, 2025

fix: resolve claude-code provider image hang (#5100) (#5105)

8824cd9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Daniel <57051444+daniel-lxs@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: resolve claude-code provider image hang (#5100) #5105

fix: resolve claude-code provider image hang (#5100) #5105

Uh oh!

hannesrudolph commented Jun 25, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

delve-auditor bot commented Jun 25, 2025 •

edited

Loading

Uh oh!

daniel-lxs left a comment

Uh oh!

Uh oh!

kaizendevsio commented Aug 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Search code, repositories, users, issues, pull requests...

fix: resolve claude-code provider image hang (#5100) #5105

fix: resolve claude-code provider image hang (#5100) #5105

Uh oh!

Conversation

hannesrudolph commented Jun 25, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes Made

Testing

Verification of Acceptance Criteria

Code Quality

Files Changed

Impact

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

delve-auditor bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daniel-lxs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kaizendevsio commented Aug 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hannesrudolph commented Jun 25, 2025 •

edited by ellipsis-dev bot

Loading

delve-auditor bot commented Jun 25, 2025 •

edited

Loading